Repository navigation
fix(web): sync calendar timezone hint before day redirect - #5235
Merged
Merged
Conversation
Contributor
|
Boot bundle: 576.8 KB gzip (+0.0 KB vs main) |
Apply the primary calendar zone as soon as the calendars query resolves so redirectToToday uses Denver civil day before day view column picking runs. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Week stress E2E can press d before CalendarTimeZoneHintSync runs; syncing from the calendars query cache in loadTodayData closes that race. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/day-column-stress-hint-sync-0084
branch
from
November 12, 2026 07:17
d56ae83 to
ee44b96
Compare
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Shard 4 E2E:
day view keeps calendar column labels clipped with many visible columns(expected 12 columns, got 1). Playwright usestimezoneId: UTC; stress fixtures use 12 Denver calendars with events on Denver civil today. Intermittent after #5229: passed on #5234 head2ffa64f6d, failed on4179b5b0fwhen UTC civil day is Nov 12 but events are Nov 11 Denver.Root cause:
redirectToToday/loadTodayData()ran with browser UTC before the calendar timezone hint applied (query fetch vsuseLayoutEffectvs pressingdon week).Fix: Sync
pickCalendarTimeZoneHintwhen calendars resolve (calendarsQueryOptions) and again from TanStack cache insideloadTodayData()so/dayredirects use Denver today.Verify
Unit tests:
syncCalendarTimeZoneHintFromCalendars, stressgetDayViewCalendarsmismatch cases,loadTodayDatacached-hint boundary.CI failure context: run
43170656067, job131022930946, started2026-11-12T06:48:06Z.Note
#5232 macOS hint parity is separate; this PR is web-only for merge-queue shard 4.